-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements: fillMode as Enums #18
Comments
hey @confile that's a nice idea. |
@piemonte Player is a really great lib. Thanks for sharing. |
(I know it's a bit old, but may help) @confile AVFoundation defines 3 constants:
|
@piemonte Has this been implemented? I'd like to jump into open source and this seems a simple enough addition. |
hey @matthewspear thanks for checking in. i'm swamped with some other things so feel free to submit a PR. contributions are always welcome. ✌️ |
Quite new to submitting to OS projects - How does this look? public enum FillMode: String
{
case resize = "AVLayerVideoGravityResize"
case resizeAspectFill = "AVLayerVideoGravityResizeAspectFill"
case resizeAspectFit = "AVLayerVideoGravityResizeAspect"
} one other alternative would be to just use Can make a pull request once happy with preference or have any other ideas! Matt |
Hey @matthewspear apologies, i didn't see your last comment. The way you have it is great, I'll just paste it into the class and give you props in the comment. |
👍 |
It is hard to find which fill modes are supported when they are as strings.
Could you please add the possible fill modes to the documentation or make them available with an enum?
The text was updated successfully, but these errors were encountered: