Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md: predictedState #58

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

harrisanth
Copy link
Contributor

@harrisanth harrisanth commented Mar 20, 2023

This changes examples which use variable name predictedState to predicted which is the variable name used later in examples.

I discovered this independently, but was also mentioned here: #47

Side note: are you willing to help me understand where I am going wrong or clear up my lack of understanding with using this library for online sensor fusion? I'm happy to add an example to docs if I can get this figured out.

Thanks in advance!

Note: I accidentally submitted PR with my work account; apologies if it seems too mysterious.
Here's the public me: https://github.com/crosshj. I'm happy to re-submit with my public account.

change examples which use variable name `predictedState` to `predicted` which is the variable name used later in example
@piercus
Copy link
Owner

piercus commented Mar 20, 2023

Thanks for your contribution !

Could you give more context about online sensor fusion ?

Can you please open a specific and show a simple example of what you are trying to achieve ?

Thanks

@piercus piercus merged commit 384de96 into piercus:master Mar 20, 2023
@harrisanth
Copy link
Contributor Author

Thanks for your contribution !

Could you give more context about online sensor fusion ?

Can you please open a specific and show a simple example of what you are trying to achieve ?

Thanks

Thanks for the merge and thanks for entertaining the question! I will work on example and add it to an issue with a more clearly worded question. See you soon!

@harrisanth harrisanth deleted the patch-1 branch March 20, 2023 06:36
@piercus
Copy link
Owner

piercus commented Mar 24, 2023

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants