registrobr: fix exception in https source handling #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelCoding
added a commit
to dd-ix/arouteserver.nix
that referenced
this pull request
Feb 19, 2024
|
Thanks @liske, I've merged the PR into master. The CI/CD pipeline is running now, if everything goes well, v1.21.6 will be out in about 1 hour with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to avoid to use ftp to download the registro.br db dump and prefer to use https instead. Switching the protocol in the configuration throws an exception in
RegistroBRWhoisDBDump:ERROR Can't decode Registro.br Whois DB raw file: 'str' object has no attribute 'decode' - The error occurred while loading the IRR data from https://ftp.registro.br/pub/numeracao/origin/nicbr-asn-blk-latest.txt. If the data was moved to a different location, it is possible to adjust the configuration by changing the value of 'filtering.irrdb.use_registrobr_bulk_whois_data.source' inside the general.yml file.
This patch fixes the handling of the
requests.get()response.Cheers from @dd-ix