Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registrobr: fix exception in https source handling #128

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

liske
Copy link
Contributor

@liske liske commented Feb 19, 2024

We want to avoid to use ftp to download the registro.br db dump and prefer to use https instead. Switching the protocol in the configuration throws an exception in RegistroBRWhoisDBDump:

ERROR Can't decode Registro.br Whois DB raw file: 'str' object has no attribute 'decode' - The error occurred while loading the IRR data from https://ftp.registro.br/pub/numeracao/origin/nicbr-asn-blk-latest.txt. If the data was moved to a different location, it is possible to adjust the configuration by changing the value of 'filtering.irrdb.use_registrobr_bulk_whois_data.source' inside the general.yml file.

This patch fixes the handling of the requests.get() response.

Cheers from @dd-ix

MarcelCoding added a commit to dd-ix/arouteserver.nix that referenced this pull request Feb 19, 2024
@pierky pierky merged commit c4e091e into pierky:master Feb 22, 2024
11 checks passed
@pierky
Copy link
Owner

pierky commented Feb 22, 2024

Thanks @liske, I've merged the PR into master. The CI/CD pipeline is running now, if everything goes well, v1.21.6 will be out in about 1 hour with the fix.

@liske liske deleted the fix-registro_br-via-https branch February 25, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants