Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace parseQuery with getOptions #8

Merged
merged 1 commit into from Mar 13, 2017
Merged

Replace parseQuery with getOptions #8

merged 1 commit into from Mar 13, 2017

Conversation

Tiagojdferreira
Copy link
Contributor

Why?

  • Warning during webpack2 build. Possible future breaking change

Implementation:

@Tiagojdferreira
Copy link
Contributor Author

closes #7

@Tiagojdferreira
Copy link
Contributor Author

Tiagojdferreira commented Mar 6, 2017 •
edited

Need to further test this as I just ran into an error.

@Tiagojdferreira
Replace parseQuery with getOptions
f6804b7 
Why?
* Warning during webpack2 build. Possible future breaking change

Implementation:
* Replaced parseQuery with getOptions as defined in webpack/loader-utils#56
@Tiagojdferreira
Copy link
Contributor Author

Fixed issue. Options was read only so I needed to copy it. Used object assign to do a shallow copy and then did a deep copy of the string in options.root.

@pierreant-p pierreant-p merged commit 7397e86 into pierreant-p:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tiagojdferreira @pierreant-p