Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bendin output values incorrect #104

Closed
SeanArchibald opened this issue Mar 27, 2018 · 2 comments
Closed

bendin output values incorrect #104

SeanArchibald opened this issue Mar 27, 2018 · 2 comments
Labels
Projects

Comments

@SeanArchibald
Copy link

The output from bendin is not as expected.
- Run the Test.zip project as a plugin in your DAW
- Move your keyboard pitch wheel up and down, this will show the current, min and max values received from the bendin object
- Expected results are: Min=0, Max=16384. With the pitch wheel at rest, the current value should be 8192.
- Actual results are: Min=8192, Max=16256. With pitch wheel at rest, current value is 16256

screenshot_20180327_143131

Have I made a mistake with how I'm using bendin here, or is it a bug that others can reproduce? Thanks!

My environment
- OS: Ubuntu 16.04
- DAW: Bitwig 2.2.2
- Plugin: VST2 v1.0.3
- Keyboard: M-Audio Keystation 88

pierreguillot added a commit that referenced this issue Mar 27, 2018
@pierreguillot
Copy link
Owner

You're right, libpd adds 8192 to the pitch bend value. I fixed it b4cd19c :) Thanks!
I think the maximum value is a side effect of this offset.
And are you sure that the maximum should be 16384 and not 16383?
16383 seems now consistent with libpd (so Pd) and Juce.

@pierreguillot pierreguillot added this to To do in v1.0.4 via automation Mar 27, 2018
@pierreguillot pierreguillot moved this from To do to In progress in v1.0.4 Mar 27, 2018
@SeanArchibald
Copy link
Author

The max should be 16383 - you're right.

Very happy to see this will make it into 1.0.4. Looks like this will be a very good release Pierre!!

@pierreguillot pierreguillot moved this from In progress to Done in v1.0.4 Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v1.0.4
  
Done
Development

No branches or pull requests

2 participants