Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indent, replace tabs with spaces #6

Closed
wants to merge 2 commits into from

Conversation

risseraka
Copy link

NPM scripts' paths to binaries have also been fixed to avoid having to npm install -g everything.
Hope it pleases you.
Cheers!

Protip: you can visualize changes ignoring whitespace at https://github.com/pierreinglebert/json-merge-patch/pull/6/files?w=1.

@pierreinglebert
Copy link
Owner

You don't have to install them globally, only in devDependencies. npm adds the ./node_modules/.bin to your PATH before running scripts (it also has the priority).

./node_modules/.bin/eslint --version
v1.10.0
eslint --version
v2.2.0
(add "eslint --version" to package.json under scripts.eslintv)
npm run eslintv
v1.10.0

@risseraka
Copy link
Author

Oh, indeed, just tested, didn't about that, thanks! (What a noob I am...)

What about my first commit? Mind if I open another PR with only the styling cleanup commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants