-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add unit tests #122
[WIP] Add unit tests #122
Conversation
Add another function to describe the Python ecosystem (version, install directory). Update documentation
Hi, Here a few commits to close this PR:
import pbxplore
pbxplore.tests() One small issue: usually the test folder is named "tests" and the function is named "test". Here, it's the other way. I could rename those if you want before merging. nosetests -v pbxplore/test I updated those information into the install page of the documentation by creating a chapter called "Testing PBxplore".
|
Great work @HubLot !
If you feel this is more mainstream to have the test function named Regarding @jbarnoud what do you think? |
Indeed, I'll add a test to prevent the possible error. |
I updated the PR. @jbarnoud can you review? |
I'll look at it on Saturday. On 12-05-16 16:51, Hub wrote:
|
$ python setup.py nosetests | ||
|
||
|
||
Or within the `PBxplore` package: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean that you must be in the PBxplore directory to tun this command? If not, the sentence is unclear. I would suggest something like:
Or from the `PBxplore` module
I posted a few comments. Besides these, everything looks good to me. |
I updated the PR with @jbarnoud comments. |
Hi,
I'm currently adding unit tests into the package to increase its 'robustness', specially on the different functions of the package (I think the scripts in
test_regression.py
are very well covered).I also realized that I introduced some functions before without unit tests associated (booo).