Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character names with periods aren't recognized #20

Closed
jasonmeisel opened this issue Mar 20, 2019 · 5 comments · Fixed by #22
Closed

Character names with periods aren't recognized #20

jasonmeisel opened this issue Mar 20, 2019 · 5 comments · Fixed by #22
Labels
bug Something isn't working

Comments

@jasonmeisel
Copy link

If a character name has a period in it (e.g. "MR. FOO"), it neither syntax highlights nor appears in the character list (when beginning a new character line).

@jasonmeisel
Copy link
Author

Also, hyphens!

Screen Shot 2019-03-20 at 4 31 53 PM

@piersdeseilligny
Copy link
Owner

Just added support for this, but I'm not entirely sure how fountain should behave with this. You can force character names with @, (aka @GREY-HAIRED MAN) but I don't know if special characters (like -,', ect...) should require the @.

@DaTedinator
Copy link

Not sure if I should make a new issue for this or not, but I would like to voice support for special characters not requiring an @; "GREY-HAIRED MAN" and "WOMAN'S VOICE" should both be character names without needing to be forced. Fountain.io may never say so explicitly, but I think going off of their examples and their repo that's the intended behavior.

@piersdeseilligny
Copy link
Owner

I'il update this soon. I'm busy for the next few weeks, but will definitely add support for this as soon as possible. It might involve some light refactoring though as it seems to make more sense to exclude characters which can't appear in character names, rather than include all those which can.

@piersdeseilligny
Copy link
Owner

Fixed by 1.7.0, now in the marketplace!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants