Addresses subscript out of bounds error #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I have found a fix for the error raised in piersyork#7. It's related to metadata which doesn't contain a source attribute.
instead of adding an if else statement, I moved the placement of assigning a value on the source attribute. If the source attribute is missing from the metadata, and it's the first value that's added to the `data_info` list, the rest of the list can't be populated, and it returns the "out of bound" error.
|
Hi, I still got the same problem going on after installing the package. Any updates on this? |
I don't think my proposed fix have been merged. The change is only to move one line of code, so you could try yourself in your local package copy. Or install the fork i have done, use the "patch-1" branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found a partial fix for the error raised in #7. It seems to be related to metadata which doesn't contain a
sourceattribute. I have successfully downloaded the datasets usingowid()that previously returned the error using my proposed change. However, callingowid_source()now returns an error, I guess it's because of the missingsourceattribute.I have run some queries on the OWID API, and I can't see the
sourceattribute in any of them, like these ones:Population density: https://api.ourworldindata.org/v1/indicators/734429.metadata.json
Carbon intensity of electricity generation: https://api.ourworldindata.org/v1/indicators/817696.metadata.json
Maybe they have changed some attribute names? I see an attribute named
originsthat seems to contain the source information.