phpunit.yml: extend workflow to run for all supported PHP versions (7.1 - 8.3) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k00ni
changed the title
|
Good move as well. We claim it works for specific versions of PHP in the readme so we better test it as well :) |
pietercolpaert
approved these changes
Feb 28, 2024
|
It also helps us to stay sane 😆 Thanks for the quick approval. Cheers 🍾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Github Action to run PHPUnit was a good move @pietercolpaert
I extended it so it runs our tests for each major PHP version (7.1-8.3), even though versions prior 8.0 are EOL (source: https://www.php.net/supported-versions.php).