ShellScript lint

pietrocaselani · Mar 3, 2019 · 7f43eb5 · 7f43eb5
1 parent 6007077
commit 7f43eb5
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/scripts/update_translations b/scripts/update_translations
@@ -1,7 +1,7 @@
 #!/bin/bash
 
-SCRIPTS_DIR=$(cd `dirname $0`; pwd)
-COUCH_TRACKER_CORE_DIR=$(cd $SCRIPTS_DIR/../CouchTrackerCore; pwd)
+SCRIPTS_DIR=$(cd "$(dirname "$0")" || exit 1; pwd)
+COUCH_TRACKER_CORE_DIR=$(cd "$SCRIPTS_DIR"/../CouchTrackerCore || exit 1; pwd)
 TRANSLATIONS_ZIP_PATH="${SCRIPTS_DIR}/translations.zip"
 
 function copy_to_languange() {
@@ -10,12 +10,12 @@ function copy_to_languange() {
     cp -rfv "$SCRIPTS_DIR/couchtracker-strings-archive/$LANGUAGE_DIR/Localizable.strings" "$COUCH_TRACKER_CORE_DIR/$LANGUAGE_DIR"
 }
 
-curl https://localise.biz/api/export/archive/strings.zip?key=${LOCALISE_BIZ_KEY} > $TRANSLATIONS_ZIP_PATH
+curl https://localise.biz/api/export/archive/strings.zip?key=${LOCALISE_BIZ_KEY} > "$TRANSLATIONS_ZIP_PATH"
 
-unzip $TRANSLATIONS_ZIP_PATH -d $SCRIPTS_DIR
+unzip "$TRANSLATIONS_ZIP_PATH" -d "$SCRIPTS_DIR"
 
 copy_to_languange "en.lproj"
 copy_to_languange "pt-BR.lproj"
 
-rm -rf $SCRIPTS_DIR/couchtracker-strings-archive
-rm -rf $SCRIPTS_DIR/translations.zip
+rm -rf "$SCRIPTS_DIR"/couchtracker-strings-archive
+rm -rf "$SCRIPTS_DIR"/translations.zip