Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring Tuist #196

Merged
merged 27 commits into from May 20, 2019
Merged

Configuring Tuist #196

merged 27 commits into from May 20, 2019

Conversation

pietrocaselani
Copy link
Owner

@pietrocaselani pietrocaselani commented May 18, 2019

Tuist is a tool to manage Xcode projects very similar to SPM, but works for iOS projects!

Since this project has more than a few frameworks, I think Tuist will help avoid conflicts on the CouchTracker.xcodeproj/project.pbxproj file and manage the dependencies between the frameworks.

Now the project configuration lives on the file Project.swift, located at root of the project.
It's already a big file, but I will try to figure out a better way to keep things organized.

Right now, there are still some things that need to be done

  • Add the playground to the project
  • Add missing Build Phases (Swiftlint, swiftformat and maybe more)
  • Check if the "Autobump" still works
  • Create schemes to group all tests
  • Add Debug flag again
  • Try to fix the copy of duplicated resources (Skipping duplicate build file in Copy Bundle Resources build phase: /Users/distiller/project/CouchTrackerCore/Resources/en.lproj/CouchTrackerCore.strings (in target 'CouchTrackerCore'))

About the duplicated strings resources -> tuist/tuist#361

@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #196 into master will increase coverage by 4.16%.
The diff coverage is 6.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   30.38%   34.54%   +4.16%     
==========================================
  Files         291      292       +1     
  Lines        6468     7292     +824     
==========================================
+ Hits         1965     2519     +554     
- Misses       4503     4773     +270
Impacted Files Coverage Δ
TraktSwift/Models/SearchResult.swift 0% <ø> (-100%) ⬇️
...kerCore/Shows/Progress/ShowProgressViewState.swift 100% <ø> (+16.66%) ⬆️
TraktSwift/Models/Sync/HistoryParameters.swift 0% <ø> (ø) ⬆️
TraktSwift/Models/Show/Show.swift 0% <0%> (-100%) ⬇️
TraktSwift/Models/Show/SeasonIds.swift 0% <0%> (-79.42%) ⬇️
...p/Shows/Progress/ShowsProgressViewController.swift 38.58% <0%> (+38.58%) ⬆️
TraktSwiftTests/ShowsTest.swift 0% <0%> (ø) ⬆️
TraktSwift/Models/Base/BaseEpisode.swift 0% <0%> (ø) ⬆️
TraktSwift/Models/Show/Episode.swift 0% <0%> (ø) ⬆️
TraktSwift/Models/Base/BaseTrendingEntity.swift 0% <0%> (-100%) ⬇️
... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752f774...a9917b2. Read the comment docs.

@pietrocaselani
Copy link
Owner Author

🎉

@pietrocaselani pietrocaselani merged commit 9390285 into master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants