Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating from BBC repo #2

Merged
merged 28 commits into from
Oct 2, 2019
Merged

Updating from BBC repo #2

merged 28 commits into from
Oct 2, 2019

Commits on Aug 13, 2019

  1. Develop (#175)

    * added support for docx - needs better integration altho it works
    
    * adding timecodes and speakers to plain text export
    
    * develop: Fix 159 performance problem (#171)
    
    * moved header into a component
    
    with shouldComponentUopdate false to avoid unecessary re-renders - test
    
    * moved Header component into separate file
    
    +removed unused styling, commented out for now in case it's needed, eg in mobile view?
    
    * moved playback_rates const into separate file
    
    * optimised re-render of playback rate
    
    * optimise re-render for VideoPlayer
    
    * added some notes - draft
    
    on how to prevent uncessary re-renders in React
    
    * Added some comments
    
    * small note in docs
    
    about using console.log in render to measure performance
    
    * ammend to notes
    
    * Update 2019-05-16-prevent-unnecessary-re-renders-in-react.md
    
    * notes update
    
    * notes fix
    
    * trying out why-did-you-update
    
    * updated MediaPlayer and subcomponents
    
    * made ToolTip 'how does this work' into it's own component
    
    * updated Demo app to reduce unecessary re-renders
    
    * added react-visibility-sensor
    
    * refactor settings
    
    * removed unecessary attributes from state of components + WrapperBlock performance tweak using react-visibility-sensor
    
    * develop: Update timestamps diff (#172)
    
    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added documentation
    
    * Merged timer for updating the timestamps and local save.
    
    * Selection state is now kept across updates to timestamps
    
    * Fixed bug where words with punctuation always are considered as new words. Timestamp update function now also uses the alignWords function directly instead of alignJSONText, removing some overhead.
    
    * Fixed small bug which raised an error if an empty block was present during timestamp update
    
    * Changed time of timestamp-update. Now re-calculates the timestamps after 5 seconds if the transcript has been edited or if the user saves the transcript manually with the save button
    
    * Code cleanup
    
    * develop: Murezzda update timestamps diff (#173)
    
    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added documentation
    
    * Merged timer for updating the timestamps and local save.
    
    * Selection state is now kept across updates to timestamps
    
    * Fixed bug where words with punctuation always are considered as new words. Timestamp update function now also uses the alignWords function directly instead of alignJSONText, removing some overhead.
    
    * Fixed small bug which raised an error if an empty block was present during timestamp update
    
    * Changed time of timestamp-update. Now re-calculates the timestamps after 5 seconds if the transcript has been edited or if the user saves the transcript manually with the save button
    
    * Code cleanup
    
    * some changes to show sudgestions for PR
    
    * added some of changes sudgested in PR
    
    * Update package.json
    
    * develop: Murezzda update timestamps diff dpe groups words by speaker (#174)
    
    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added timestamp update via diff tool
    
    * Added missing function
    
    * Commited intermediate state
    
    * Rewrote timestamp alignment and differ to be integrated in each other instead of doing a 2-step process.
    
    * Update Timestamps now works correctly.
    
    * Fixed errors from rebase, removed debug code
    
    * Moved UpdateTimestamp into its own folder.
    
    * added updateTimestampsSSTAlign which updates the timestamps with the sst-align code
    
    * Added documentation
    
    * Merged timer for updating the timestamps and local save.
    
    * Selection state is now kept across updates to timestamps
    
    * Fixed bug where words with punctuation always are considered as new words. Timestamp update function now also uses the alignWords function directly instead of alignJSONText, removing some overhead.
    
    * Fixed small bug which raised an error if an empty block was present during timestamp update
    
    * Changed time of timestamp-update. Now re-calculates the timestamps after 5 seconds if the transcript has been edited or if the user saves the transcript manually with the save button
    
    * Code cleanup
    
    * some changes to show sudgestions for PR
    
    * added some of changes sudgested in PR
    
    * adjusted DPE adapter
    
    so that it preserves paragraphs break within contiguos speakers
    
    * fixed one test
    
    * commented out auto align
    
    left aligning as a step before save btn and before export function, rather then as a step that happens everytime autosave is triggered, as that might be unecessary, and add performance overhead, I also noticed the cursor position jumped after realignement, thought something was been put in place to preserve/avoid that?
    
    * updated package-lock
    
    * fixed vulneranilities
    
    * Getting ready to publish alpha
    
    * 1.0.4-alpha.0
    
    * 1.0.4@alpha
    
    * fixed notes
    
    * changing speaker and timecodes to be unselectable
    
    * 1.0.4-alpha.1
    
    * 1.0.4-alpha.1
    
    unselectabel speakers and timecodes
    
    * fix speaker and timecodes at paragraph level after realignement
    
    * 1.0.4-alpha.2
    
    * fixed docx integration
    
    * Subtitles export (#168)
    
    * added option to export srt files
    
    and layout to export other type of captions with auto segmentation of lines
    
    * added support for other subtitles formats
    
    * fixed npm audit
    
    * implemented export in UI
    
    * fixed test
    
    added sample files for adding tests for subtitle composer module at later stage
    
    * added optional analytics
    
    for export download options
    
    * updated CSS
    
    * 1.0.4-alpha.3
    
    * fixed subtiles segmentation
    
    algo was picking the wrong words from the list
    
    * moved PR template in github folder
    
    * cleaned up code for subtitles parsing
    
    * 1.0.4-alpha.4
    
    * fixed alignement algo
    
    after interpolation words time boundares  where overlapping
    
    * fixed interpolation
    
    * fixed filename of word doc export
    
    * fixed TimeBox
    
    and playback rate not working
    
    * 1.0.4-alpha.5
    
    * removed scroll sync (#181)
    
    fix #180
    
    * refactor
    
    changes from James review #160
    
    * Develop branch -  should component update refactor (#182)
    
    * Refactor should component updatre for transcript editor
    
    * Refactor should component updatre for PlayerControls
    
    * Refactor should component updatre for TimeBox
    
    * Refactor should component update for ProgressBar
    
    * Refactor should component update for TimedTextEditor
    
    * Refactor should component update for Header
    
    * fix from PR review
    
    Fixed from James comments from #144 (review)
    
    * Update package.json
    
    * Update package.json
    Pietro committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    6cfca7b View commit details
    Browse the repository at this point in the history
  2. fixed vulernerabilities

    Pietro Passarelli - News Labs committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    69f6b21 View commit details
    Browse the repository at this point in the history
  3. 1.0.5

    Pietro Passarelli - News Labs committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    be685c9 View commit details
    Browse the repository at this point in the history
  4. fixed vulnerabilities + added webpack-cli as dev dependency

    Pietro Passarelli - News Labs committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    e301db1 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. Fix: fonts

    jamesdools committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    5657ecc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    639bc29 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f14de0 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. fix should component update (#186)

    more info #185 (comment)
    Pietro committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    c1172a4 View commit details
    Browse the repository at this point in the history
  2. 1.0.6

    Pietro Passarelli - News Labs committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    430af3c View commit details
    Browse the repository at this point in the history
  3. Fixes bug where editor grabs focus on text-realigment even if editor …

    …is not in focus. (#189)
    murezzda authored and Pietro committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    8500b11 View commit details
    Browse the repository at this point in the history
  4. 1.0.7

    Pietro Passarelli - News Labs committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    b0a3c15 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2019

  1. Configuration menu
    Copy the full SHA
    45c324d View commit details
    Browse the repository at this point in the history
  2. Fix: tidy demo styling

    jamesdools committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    b1c2d38 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c3448e3 View commit details
    Browse the repository at this point in the history
  4. Refactor: function cleanup

    jamesdools committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    3aa42d6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9866f23 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. Configuration menu
    Copy the full SHA
    9557faa View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. storybook, npm, webpack setup - draft (#184)

    * draft
    
    * Updated docs with feedback
    Pietro authored and emettely committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    0713129 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. Configuration menu
    Copy the full SHA
    c6de274 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6d2970a View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. Configuration menu
    Copy the full SHA
    c62f410 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. Merge

    jamesdools committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    1ba95a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8723a0b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6f29c3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e7a988 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #183 from bbc/refactor-media-player

    Refactor media player
    jamesdools committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    c06416a View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. Speechmatics adapter update (#190)

    * Fixed bug in speechmatics adapter: Speaker-time was compared as string values, which resulted in wrong speaker assignment in some cases
    
    * Updated speechmatics adapter to create paragraphs according to speaker name instead of end-of-sentence symbols.
    
    * Added additional paragraph break rule: 150 words in paragraph and sentence end.
    
    * Adjusted comments for groupWordsInParagraphs
    
    * Updated test-result for speechmatics-to-draft
    murezzda authored and emettely committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    d199690 View commit details
    Browse the repository at this point in the history
  2. Fix: npm audit

    jamesdools committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    51d486e View commit details
    Browse the repository at this point in the history