Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub repo icon missing #22

Closed
pietroppeter opened this issue Jun 5, 2021 · 4 comments
Closed

GitHub repo icon missing #22

pietroppeter opened this issue Jun 5, 2021 · 4 comments

Comments

@pietroppeter
Copy link
Owner

Not sure why, but we lost the GitHub repo icon. At a first look code looks fine: repo url is set in nbook, should be dumped in book.json, should be loaded in useNimibook and put in the context.

@pietroppeter
Copy link
Owner Author

I checked and in book.json both title and git_repository_url are missing

@pietroppeter
Copy link
Owner Author

well, title is never populated so that is fine. The weird thing is that using dump the json is correct. Doing build I cannot see anywhere where the book.json is generated. Sending a fix for this now, but if someone know what is happening in this case let me know.

@HugoGranstrom
Copy link
Collaborator

HugoGranstrom commented Jun 5, 2021

I think the problem was that dump is called already in newBookFromToc here and we add the repo link afterwards. So the correct placement is where you have put it now.

@pietroppeter
Copy link
Owner Author

Ah good spotting, that is where it was, I will remove it from there

pietroppeter added a commit that referenced this issue Jun 7, 2021
* it was added in publish see #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants