Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mismatch method queries return multiple copies of the same method #7

Closed
emilyy-dev opened this issue Dec 28, 2020 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@emilyy-dev
Copy link
Contributor

Description

Some (not all) mismatched method queries suggest certain methods multiple times when there is only one of them

Examples

Spigot's ServicesManager only contains one load method yet it shows multiple:
image

The JDK's Map class contains in reality a single get method:
image

@PiggyPiglet
Copy link
Owner

That's super weird. Iirc I'm returning a set in the query, duplicates shouldn't be possible. Not to mention, the actual data structure storing the objects is a set. Really not sure what's going on here, perhaps my hashcode/equals impl might be outdated

@PiggyPiglet PiggyPiglet added the bug Something isn't working label Dec 31, 2020
@PiggyPiglet
Copy link
Owner

Thought this could be solved via #9, but it looks like the issue actually stems from the fact that the identifier in the documented object, isn't actually necessarily what the object is actually called. For example, you can search for servicesmanager#load & simpleservicesmanager, but they both return the exact same object. I'm going to create a new type which is returned by the endpoint which contains the actual name the object is referenced by in memory, along with the object itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants