Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transliteration of notifications #272

Merged
merged 2 commits into from Oct 8, 2023
Merged

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Sep 29, 2023

It seems pinetime have troubles to draw non-ascii letters. Here, I am proposing solution for that. I still have some questions, but this proof of concept works

On the attached photos I have received message "Čeština je řeč králů" (Czech language is language of kings) on telegram from Pavel Kerék. Not sure about other languages, but for me it works.

image20230929_093924783
image20230929_093930271

There are also other questions:

  • is icu the right library? It seems to be dependency of Qt, hence I expect its availability on all platforms.
  • where should be transliteration added? I have added it just for PineTime device into sendAlert() function, but same trouble will be with phone calls. It can be done also somewhere in libwatchface after getting the notification, or somewhere else yet.
  • How is this solved with for other devices? Does they provide those characters?
  • Is transliteration on smartphone the right way? It seems gadgetbridge have transliteration as configurable option. It seems to be recommended at Internationalization for Notification InfiniTimeOrg/InfiniTime#1490

@piggz
Copy link
Owner

piggz commented Oct 6, 2023

  1. I think the ICU library is the correct solution for this.
  2. Ill have to think about where to implement this.....I know the amazit devices support a range of languages, so maybe less of an issue there

@piggz
Copy link
Owner

piggz commented Oct 8, 2023

Ok, lets merge this as-is for now, and if we have other use cases, can expand its use later. thanks

@piggz piggz merged commit 4ba3329 into piggz:master Oct 8, 2023
@jmlich jmlich deleted the transliteration branch October 9, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants