Send title separated by 0x00 from rest of notifications #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazfish introduced configurable separator in February 2021 piggz@0638cc7 infinitime introduced 0x00 separator for notification content in April 2021 InfiniTimeOrg/InfiniTime@03de1c6
|
p.s. it would be great to add #hacktoberfest topic to the project |
|
Youll have to explain to me what adding #hacktoberfest will do :) |
|
There is an web site about that https://hacktoberfest.com/ Basically, every merged merge request counts to competition. After 3 accepted merge requests I will get an reward. This year the reward is planted tree in my name. |
|
Sounds like a good enough reason! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amazfish introduced configurable separator in February 2021 0638cc7
infinitime introduced 0x00 separator for notification content in April 2021
InfiniTimeOrg/InfiniTime@03de1c6
Using 0x00 separator will improve layout notifications in PineTime. See screenshots.