Add Ubuntu Touch support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README to reflect current state and name of the app, and mention libcamera, as this is a main factor susceptible to drive adoption. Signed-off-by: Sumwun Ducainest <sumwun.ducainest@outlook.com>
The app used to have a pre-generated shutter.qrc that pointed to the platform.kirigami QML files independently of the chosen flavor. As far as I can tell, this prevents the app from building correctly for other flavors. This commit replaces `shutter.qrc` with `shutter.qrc.in` and adds a step in `harbour-shutter.pro` to replace the `@FLAVOR@` placeholder. Signed-off-by: Sumwun Ducainest <sumwun.ducainest@outlook.com>
This commit adds a directory containing files specific to the build system used for Ubuntu Touch apps: [Clickable](https://clickable-ut.dev). Signed-off-by: Sumwun Ducainest <sumwun.ducainest@outlook.com>
This commit adds a bare-bones YAML build file for the build system used in Ubuntu Touch apps: [clickable](https://clickable-ut.dev). That build file is not yet functional. Signed-off-by: Sumwun Ducainest <sumwun.ducainest@outlook.com>
This commit adds the QtMultimedia qvideoframe_p.h private header to the Ubuntu Touch-specific files. This is necessary, because Qt no longer distributes private headers, so the package containing the header is not available on Ubuntu. In time, the use of this header should be replaced by the Qt-recommended way of doing things. Signed-off-by: Sumwun Ducainest <sumwun.ducainest@outlook.com>
Shutter relies on 2 libraires that are unavailable in the Focal (20.04) repos that Ubuntu Touch is currently still using: - libcamera - libopencv For Ubuntu Touch, we therefore need to build AND ship those libraries with the app. This commit adds the clickable configuration to do that, as well as a script that will be used to build libcamera. Signed-off-by: Sumwun Ducainest <sumwun.ducainest@outlook.com>
The Ubuntu Touch build is going to use the Kirigami flavor. However, the version of Kirigami available in the Focal (20.04) repos currently used by Ubuntu Touch is 2.5 This commit creates a new platform.kirigami/ut/ directory containing QML files using Kirigami 2.5 instead of 2.14. Once Ubuntu Touch has moved to Noble (24.04), these can probably be removed. Signed-off-by: Sumwun Ducainest <sumwun.ducainest@outlook.com>
This commit adds the QMake configurations necessary for the Ubuntu Touch build to succeed. Signed-off-by: Sumwun Ducainest <sumwun.ducainest@outlook.com>
Add build instructions for Ubuntu Touch to the README. Signed-off-by: Sumwun Ducainest <sumwun.ducainest@outlook.com>
|
Looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first PR to support Ubuntu Touch devices.
It is a Work In Progress, but I have confirmed that it works on my Pine Phone.
The app currently segfaults on my PinePhone Pro, I'm planning to take a look at that next.
I have tried to keep the UT-specific stuff out of the way of the main tree as much as possible.
There are a few "hacks" due to Ubuntu Touch being stuck on an oldish version for now (20.04).
This should hopefully change in the near future.