Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goesimage loses error codes from the processes that it runs #2

Closed
yurivict opened this issue May 26, 2019 · 2 comments
Closed

goesimage loses error codes from the processes that it runs #2

yurivict opened this issue May 26, 2019 · 2 comments

Comments

@yurivict
Copy link

yurivict commented May 26, 2019

For example, at some point convert began to fail and the goesimage still succeeds, and it doesn't print any message saying that the child process failed.

pigmonkey added a commit that referenced this issue Jun 1, 2019
@pigmonkey
Copy link
Owner

Does the latest master work for you? I'm only wrapping curl, feh, and convert. Doing it for more common utils like mkdir and file seems like overkill, but I suppose we could wrap those as well.

I'm not returning the exit code of the failed process, as they may conflict with the exit codes returned by goesimage.

@yurivict
Copy link
Author

yurivict commented Jun 1, 2019

Thanks for fixing this.

@yurivict yurivict closed this as completed Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants