Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assist action and built-in hass-action #1173

Merged
merged 3 commits into from Jun 28, 2023
Merged

Add assist action and built-in hass-action #1173

merged 3 commits into from Jun 28, 2023

Conversation

piitaya
Copy link
Owner

@piitaya piitaya commented Jun 21, 2023

Description

These features requires 2023.7 ha version.

This PR replaces custom actions by the built-in hass-action event.

This will improve some things :

  • allow to open assist from mushroom card
  • use ha dialog instead of browser popup for confirmations

Related Issue

This PR fixes or closes issue: fixes #541, fixes #1109

Motivation and Context

How Has This Been Tested

Types of changes

  • 馃悰 Bug fix (non-breaking change which fixes an issue)
  • 馃殌 New feature (non-breaking change which adds functionality)
  • 馃寧 Translation (addition or update a translation)
  • 鈿狅笍 Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

@piitaya piitaya changed the title Add assist action Add assist action and built-in hass-action Jun 21, 2023
@piitaya piitaya added the enhancement New feature or request label Jun 21, 2023
@piitaya piitaya merged commit ed4d45d into main Jun 28, 2023
2 checks passed
@dnestico dnestico mentioned this pull request Jul 6, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: "Assist" Chip in Chips Card [Feature]: Styled (instead of browser) action confirmation popups
1 participant