Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(actions): add double tap action of all card #123

Merged
merged 1 commit into from
Feb 15, 2022
Merged

feat(actions): add double tap action of all card #123

merged 1 commit into from
Feb 15, 2022

Conversation

piitaya
Copy link
Owner

@piitaya piitaya commented Feb 14, 2022 •
edited

fix #122

@piitaya piitaya requested a review from bemble February 14, 2022 21:40
bemble
bemble approved these changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@bemble bemble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌
OK for now, but I think we'll have to make a MushroomCard class with common stuff and nearly all cards should extend this one. When we'll be able to handle tabs in configurator, we also should create common "global" configuration tab with hold, tab, double tap action etc.

@piitaya piitaya merged commit e1623b7 into main Feb 15, 2022
@piitaya piitaya deleted the feat/double_tap_action branch February 15, 2022 08:26
@piitaya piitaya added the enhancement New feature or request label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bemble bemble bemble approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add double_tap action
2 participants
@piitaya @bemble