Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chips): add alignment #124

Merged
merged 3 commits into from
Feb 15, 2022
Merged

feat(chips): add alignment #124

merged 3 commits into from
Feb 15, 2022

Conversation

bemble
Copy link
Collaborator

@bemble bemble commented Feb 14, 2022

Allow user to set alignment of chips.

closes #111

@bemble bemble requested a review from piitaya February 14, 2022 21:47
Copy link
Owner

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !
What about left, right instead of line-end line-start?
We can create a alignment picker like the color picker too but it can be future refactoring 😁

@bemble
Copy link
Collaborator Author

bemble commented Feb 14, 2022

Nice ! What about left, right instead of line-end line-start? We can create a alignment picker like the color picker too but it can be future refactoring 😁

Because line-start and line-end let us free about LTR and RTL stuff.
For the alignment picker, I thought about it and my conclusion is "if it's applicable for another component, sure we'll create an alignment picker".

@piitaya
Copy link
Owner

piitaya commented Feb 14, 2022

Or just start and end like flex stuff ?
Or row instead of line ? I think "ligne" translation is "row" in this case.

@bemble
Copy link
Collaborator Author

bemble commented Feb 15, 2022

Or just start and end like flex stuff ? Or row instead of line ? I think "ligne" translation is "row" in this case.

justify-content uses line-start and line-end, that's why I used it :)

@piitaya
Copy link
Owner

piitaya commented Feb 15, 2022

Or just start and end like flex stuff ? Or row instead of line ? I think "ligne" translation is "row" in this case.

justify-content uses line-start and line-end, that's why I used it :)

It's flex-start and flex-end 😅

@bemble
Copy link
Collaborator Author

bemble commented Feb 15, 2022

Or just start and end like flex stuff ? Or row instead of line ? I think "ligne" translation is "row" in this case.

justify-content uses line-start and line-end, that's why I used it :)

It's flex-start and flex-end 😅

Hahaha, indeed, too tired :)
I change the translation and property values.

src/translations/fr.json Outdated Show resolved Hide resolved
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
@bemble bemble merged commit 3a885a6 into main Feb 15, 2022
@piitaya piitaya deleted the feat/chips_alignment branch February 15, 2022 12:57
@piitaya piitaya added the enhancement New feature or request label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chips] Select chips horizontal alignment
2 participants