feat(layout): add default, horizontal and vertical layout for all cards #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
force-pushed
the
feat/card_layout
branch
from
7c4fad6
to
f8d2880
Compare
piitaya
changed the title
zsarnett
reviewed
Feb 17, 2022
zsarnett
reviewed
Feb 17, 2022
zsarnett
reviewed
Feb 17, 2022
zsarnett
reviewed
Feb 17, 2022
zsarnett
reviewed
Feb 17, 2022
Comment on lines
+31
to
+49
| <paper-dropdown-menu .label=${this.label}> | ||
| <paper-listbox | ||
| slot="dropdown-content" | ||
| attr-for-selected="value" | ||
| .selected=${this.value ?? ""} | ||
| .configValue=${this.configValue} | ||
| @iron-select=${this._selectChanged} | ||
| > | ||
| <paper-item value=""> | ||
| ${customLocalize("editor.form.layout_picker.values.default")} | ||
| </paper-item> | ||
| <paper-item .value=${"vertical"}> | ||
| ${customLocalize("editor.form.layout_picker.values.vertical")} | ||
| </paper-item> | ||
| <paper-item .value=${"horizontal"}> | ||
| ${customLocalize("editor.form.layout_picker.values.horizontal")} | ||
| </paper-item> | ||
| </paper-listbox> | ||
| </paper-dropdown-menu> |
There was a problem hiding this comment.
This will most likely not work with the next release of HA. The frontend has been striped of all Paper Drop downs and in place used mwc-select
bemble
requested changes
Feb 17, 2022
| protected render(): TemplateResult { | ||
| console.log(this.noCardStyle); | ||
| if (this.noCardStyle) { | ||
| return this.renderContent(); |
There was a problem hiding this comment.
So you handled #57 in the same time?
There was a problem hiding this comment.
Nop, it's a workaround for the alarm card but we can use this property in the future
Comment on lines
+31
to
+49
| <paper-dropdown-menu .label=${this.label}> | ||
| <paper-listbox | ||
| slot="dropdown-content" | ||
| attr-for-selected="value" | ||
| .selected=${this.value ?? ""} | ||
| .configValue=${this.configValue} | ||
| @iron-select=${this._selectChanged} | ||
| > | ||
| <paper-item value=""> | ||
| ${customLocalize("editor.form.layout_picker.values.default")} | ||
| </paper-item> | ||
| <paper-item .value=${"vertical"}> | ||
| ${customLocalize("editor.form.layout_picker.values.vertical")} | ||
| </paper-item> | ||
| <paper-item .value=${"horizontal"}> | ||
| ${customLocalize("editor.form.layout_picker.values.horizontal")} | ||
| </paper-item> | ||
| </paper-listbox> | ||
| </paper-dropdown-menu> |
| }; | ||
| export function getLayoutFromConfig(config: ConfigWithLayout): Layout { | ||
| // Backward compatibility for vertical option | ||
| return config.layout ?? (Boolean(config.vertical) ? "vertical" : "default"); |
There was a problem hiding this comment.
Nice to thought about that :)
piitaya
force-pushed
the
feat/card_layout
branch
from
65ff715
to
9ce3072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add different layout for all card :
The
layoutoption replace theverticaloption. A backward compatibility is added.fix #34
Some examples
Light card
Entity card
Fan card
Cover card
Alarm card