Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(humidifier): add humidifier support #346

Merged
merged 16 commits into from
May 8, 2022

Conversation

acesyde
Copy link
Contributor

@acesyde acesyde commented Apr 16, 2022

Description

Add humidifier / dehumidifier card support

humidifier-dark
humidifier-light

Related Issue

Fixes #379

Motivation and Context

Provide a mushroom card for humidifier / dehumidifier

How Has This Been Tested

With hassio in local

Types of changes

  • 🐛Bug fix (non-breaking change which fixes an issue)
  • 🚀New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@acesyde
Copy link
Contributor Author

acesyde commented Apr 16, 2022

@piitaya ready to review

@NimlothPL
Copy link

You may want to change title: Lock ;)

@piitaya piitaya added the enhancement New feature or request label Apr 22, 2022
@acesyde
Copy link
Contributor Author

acesyde commented Apr 29, 2022

@piitaya based on MushroomBaseElement R2R :)

@anhnvme
Copy link

anhnvme commented May 5, 2022

@piitaya please accept this pull. I'm waitting this card for long time. Thank you !

Copy link
Owner

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙂
Is it possible to remove the button control? Fan and light doesn't have on/off buttons because it's possible to toggle it using tap_action.

@anhnvme I do this on my free time so I can't be always reactive 😅

@anhnvme
Copy link

anhnvme commented May 7, 2022

@piitaya

Yes i know that. I see pull commit and wait for long time before I mention you. :D thank for reply

@acesyde
Copy link
Contributor Author

acesyde commented May 7, 2022

@piitaya . @anhnvme done ;)

@piitaya piitaya merged commit 7f096bf into piitaya:main May 8, 2022
@acesyde acesyde deleted the feature/humidifier branch May 8, 2022 09:23
ulic75 added a commit to ulic75/lovelace-mushroom that referenced this pull request May 9, 2022
* Update Vietnamese translation (piitaya#448)

* Update vi.json

* Change "Chip" to "chip"

* feat(humidifier): add humidifier support (piitaya#346)

* feat(humidifier): card

* feat(humidifier): improve card

* fix: view name

* fix: humidity live

* fix: MushroomBaseElement

* fix: clean unused dependencies

* fix: hacard

* fix: collapsible controls

* fix: remove buttons control

* fix: remove buttons control

* fix(humidifier): some fixes (piitaya#451)

* fix: remove console.log

* feat(media-player): show volume next to state when not unavailable/unknown/off (piitaya#374)

* Show volume next to state

* Revert "Show volume next to state"

This reverts commit c40e32f.

Undo due to suggestion from @acesyde

* Reworked volume state based on feedback

Co-authored-by: Paul Bottein <paul.bottein@gmail.com>

* feat(media-player): add option to display volume level (piitaya#452)

* chore: bump deps (piitaya#453)

* 1.8.0

Co-authored-by: redphx <96280+redphx@users.noreply.github.com>
Co-authored-by: Pierre-Emmanuel Mercier <acesyde@gmail.com>
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
Co-authored-by: madmurl0c <42262826+madmurl0c@users.noreply.github.com>
ulic75 added a commit to ulic75/lovelace-mushroom that referenced this pull request May 12, 2022
* Update Vietnamese translation (piitaya#448)

* Update vi.json

* Change "Chip" to "chip"

* feat(humidifier): add humidifier support (piitaya#346)

* feat(humidifier): card

* feat(humidifier): improve card

* fix: view name

* fix: humidity live

* fix: MushroomBaseElement

* fix: clean unused dependencies

* fix: hacard

* fix: collapsible controls

* fix: remove buttons control

* fix: remove buttons control

* fix(humidifier): some fixes (piitaya#451)

* fix: remove console.log

* feat(media-player): show volume next to state when not unavailable/unknown/off (piitaya#374)

* Show volume next to state

* Revert "Show volume next to state"

This reverts commit c40e32f.

Undo due to suggestion from @acesyde

* Reworked volume state based on feedback

Co-authored-by: Paul Bottein <paul.bottein@gmail.com>

* feat(media-player): add option to display volume level (piitaya#452)

* chore: bump deps (piitaya#453)

* 1.8.0

* Update README.md

* Update German translation (piitaya#458)

* Update de.json

* Update de.json

* Update de.json

* Update zh-Hant.json (piitaya#455)

* Update alarm card documentation according to piitaya#376 (piitaya#459)

* Allow customizing badge, button, shape, slider sizes (piitaya#464)

* Allow customizing badge, button, shape, slider sizes

* Add --shape-avatar-size

* feat(themes): improve css variables (piitaya#466)

* fix(chip): fix avatar size for chip

* fix(chip): add avatar only support (piitaya#468)

* fix(actions): allow scroll within actions (piitaya#469)

* Fix strict error handling in templates (piitaya#472)

* Update German translation (piitaya#474)

* Update de.json

* Update de.json

* Update de.json

* Update de.json

* 1.8.1

* Update README to reflect recent UI changes in HA 2022.5 (piitaya#470)

* fix(ios): fix button size on ios

* 1.8.2

* Update Italian translation (piitaya#478)

Added humidity control translation
Added show volume translation

* 1.8.3

* update for new css variables

Co-authored-by: redphx <96280+redphx@users.noreply.github.com>
Co-authored-by: Pierre-Emmanuel Mercier <acesyde@gmail.com>
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
Co-authored-by: madmurl0c <42262826+madmurl0c@users.noreply.github.com>
Co-authored-by: steffenrapp <88974099+steffenrapp@users.noreply.github.com>
Co-authored-by: rhuba8324 <53090204+rhuba8324@users.noreply.github.com>
Co-authored-by: Julien Ehrhart <julien.ehrhart@live.com>
Co-authored-by: Franck Nijhof <git@frenck.dev>
Co-authored-by: Doryx <81909485+doryxbirb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Add humidifier card
4 participants