Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add theme usage #46

Merged
merged 1 commit into from Feb 8, 2022
Merged

feat: add theme usage #46

merged 1 commit into from Feb 8, 2022

Conversation

piitaya
Copy link
Owner

@piitaya piitaya commented Feb 6, 2022 •
edited

The theme has moved to a now repository to be compatible with hacs : https://github.com/piitaya/lovelace-mushroom-themes

@piitaya piitaya marked this pull request as ready for review February 6, 2022 19:33
@piitaya piitaya requested a review from bemble February 6, 2022 19:33
@bemble bemble added the enhancement New feature or request label Feb 8, 2022
bemble
bemble requested changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@bemble bemble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I think the theme doc should be move to a dedicated file.
There is a more global point about the doc, maybe the wiki or a generated website, later, could be better than these files.

README.md Show resolved Hide resolved
bemble
bemble approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@bemble bemble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@piitaya piitaya merged commit e4a291c into main Feb 8, 2022
@bemble bemble linked an issue Feb 8, 2022 that may be closed by this pull request
Idea: Allow colored icons/sliders corresponding to theme color #54
Closed
@piitaya piitaya deleted the feat/theme branch February 9, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bemble bemble bemble approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: Allow colored icons/sliders corresponding to theme color
2 participants
@piitaya @bemble