comply with new convention to have column names "region", "country", "superregion" in mappings #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
everything ready except buildLibrary |
DavidhoPIK
changed the title
|
I also ran magpie with the new preprocessing with h16 and h16s5 and results looked normal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new convention of the column names in mappings is to use "country", "region", "superregion". This MR changes the toolApplyRegionNames in a way to use these new column names. If the column names in the old convention "CountryCode" "RegionCode" are provided they are automatically replaced by those of the new convention.
It was tested that this MR fixes an error in the H16s5 preprocessing, while not crashing H12 preprocessing. See for h12
rev4.106h12_David_test_change_in_toolApplyRegionNames_h12_magpie.tgz,rev4.106h12_David_test_change_in_toolApplyRegionNames_h12_validation.tgz,rev4.106h12_David_test_change_in_toolApplyRegionNames_h12_bd86374e_cellularmagpie_c200_MRI-ESM2-0-ssp370_lpjml-8e6c5eb1_clusterweight-ba4466a8.tgz,and for h16s5
rev4.106h16s5_David_test_change_in_toolApplyRegionNames_1028489d_magpie.tgzrev4.106h16s5_David_test_change_in_toolApplyRegionNames_1028489d_validation.tgzrev4.106h16s5_David_test_change_in_toolApplyRegionNames_1028489d_bd86374e_cellularmagpie_c200_MRI-ESM2-0-ssp370_lpjml-8e6c5eb1_clusterweight-ba4466a8.tgz.Version h16 was not tested but should also work, due to similarity with h16s5.