Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check SDP post-processing variables #266

Closed
orichters opened this issue Mar 11, 2024 · 2 comments
Closed

Check SDP post-processing variables #266

orichters opened this issue Mar 11, 2024 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@orichters
Copy link
Contributor

When checking the templates, we noticed that many variables do not seem to come from REMIND or MAgPIE or EDGE-T or MAGICC, but rather from some SDP-related post-processing. So we allocated source = S to them in line with the tutorial.

library(piamInterfaces)
sort(unique(unlist(lapply(c("AR6", "SHAPE", "NAVIGATE"), getTemplateVariables, "S"))))

It would be nice if you, @bs538, whenever you have nothing to do at some point, could have a short look whether that list is accurate.

@orichters orichters added the question Further information is requested label Mar 11, 2024
@bs538
Copy link
Contributor

bs538 commented Jun 12, 2024

Thanks @orichters , that's very useful for bookkeeping. The above code snippet didn't work for me (function getTemplateVariables wasn't found), but I had a quick manual look through the three templates, filtering for source == S.
Generally the assignment is correct. Though note that I didn't do the opposite check of checking whether there were any assignments of source = S missing.
Population|Urban is perhaps an edge case. The numbers came basically directly out of "madrat::calcOutput("Urban", aggregate = T)", but it's true that only our then-SDP-post-processing created the reporting variable. So fine to keep source = S there.

@orichters
Copy link
Contributor Author

Excellent. As I did some checks that there is not R variable that REMIND is not producing etc., I think we are fine now. Also, it doesn't really matter if some of these assignments is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants