Refactor socket writing to not use sendall #481

socket.sendall should not be used on non-blocking sockets.

pika/adapters/base_connection.py

@@ -353,17 +353,20 @@ def _handle_read(self):
 
     def _handle_write(self):
         """Handle any outbound buffer writes that need to take place."""
-        bytes_written = 0
         if self.outbound_buffer:
             frame = self.outbound_buffer.popleft()
             try:
-                self.socket.sendall(frame)
-                bytes_written = len(frame)
+                bytes_written = self.socket.send(frame)
+                if bytes_written < len(frame):
+                    LOGGER.debug("Could not write the full frame")
+                    self.outbound_buffer.appendleft(frame[bytes_written:])
+                return bytes_written
             except socket.timeout:
+                self.outbound_buffer.appendleft(frame)
                 raise
             except socket.error as error:
+                self.outbound_buffer.appendleft(frame)
                 return self._handle_error(error)
-        return bytes_written
 
     def _init_connection_state(self):
         """Initialize or reset all of our internal state variables for a given