Skip to content

Commit

Permalink
Merge branch 'aeirola-master'
Browse files Browse the repository at this point in the history
  • Loading branch information
gmr committed May 20, 2015
2 parents 0174fb8 + c81f02c commit 851ee1c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
6 changes: 4 additions & 2 deletions pika/channel.py
Original file line number Diff line number Diff line change
Expand Up @@ -998,8 +998,10 @@ def _on_return(self, method_frame, header_frame, body):
"""
if not self.callbacks.process(self.channel_number, '_on_return', self,
(self, method_frame.method,
header_frame.properties, body)):
self,
method_frame.method,
header_frame.properties,
body):
LOGGER.warning('Basic.Return received from server (%r, %r)',
method_frame.method, header_frame.properties)

Expand Down
11 changes: 7 additions & 4 deletions tests/unit/channel_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -1120,10 +1120,13 @@ def test_onreturn(self):
header_value = frame.Header(1, 10, spec.BasicProperties())
body_value = frame.Body(1, b'0123456789')
self.obj._on_return(method_value, header_value, body_value)
self.obj.callbacks.process.assert_called_with(
self.obj.channel_number, '_on_return', self.obj,
(self.obj, method_value.method, header_value.properties,
body_value))
self.obj.callbacks.process.assert_called_with(self.obj.channel_number,
'_on_return',
self.obj,
self.obj,
method_value.method,
header_value.properties,
body_value)

@mock.patch('logging.Logger.warning')
def test_onreturn_warning(self, warning):
Expand Down

0 comments on commit 851ee1c

Please sign in to comment.