Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect_backpressure not working with deque #347

Closed
cooper6581 opened this issue May 24, 2013 · 5 comments
Closed

detect_backpressure not working with deque #347

cooper6581 opened this issue May 24, 2013 · 5 comments

Comments

@cooper6581
Copy link
Contributor

outbound_buffer doesn't have the size property anymore, so the detect_backpressure method throws the following:

File "/usr/local/lib/python2.7/dist-packages/pika-0.9.13-py2.7.egg/pika/connection.py", line 972, in _detect_backpressure
  if self.outbound_buffer.size > (avg_frame_size * self._backpressure):
AttributeError: 'collections.deque' object has no attribute 'size'
@eandersson
Copy link
Contributor

I think this goes beyond the missing size attribute, or the behavior is different in 0.9.13. Even after adding a new implementation for size, I was still unable to get back-pressure working as excepted.

@gmr
Copy link
Member

gmr commented May 27, 2013

Sorry, totally didn't think about this when trying to streamline the codebase. I'll have it fixed soon.

On Monday, May 27, 2013 at 7:07 PM, eandersson wrote:

I think this goes beyond the missing size attribute, or the behavior is different in 0.9.13. Even after adding a new implantation for size, I was still unable to get back-pressure working.


Reply to this email directly or view it on GitHub (#347 (comment)).

@gmr
Copy link
Member

gmr commented May 29, 2013

Please give this a try if you can.

@cooper6581
Copy link
Contributor Author

Looks good so far! Thanks for the quick turn-around. I'll try and get some more testing in this weekend.

@gmr
Copy link
Member

gmr commented May 30, 2013

Great, this will be included with 0.9.14

@gmr gmr closed this as completed May 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants