BlockingConnection._handle_timeout() logic error

[vitaly-krugl]

This block of code doesn't make sense:

        if self.is_closing and self._socket_timeouts > threshold:
            if not self.is_closing:
                LOGGER.critical('Closing connection due to timeout')
            self._on_connection_closed(None, True)

if if self.is_closing and self._socket_timeouts > threshold is true, then the inner if not self.is_closing can never be true. Did the author intend the outer check to be if self.is_closing or self._socket_timeouts > threshold instead (or vs. and)?

Here is the entire method for context:

    def _handle_timeout(self):
        """Invoked whenever the socket times out"""
        self._socket_timeouts += 1
        threshold = (self.SOCKET_TIMEOUT_THRESHOLD if not self.is_closing else
                     self.SOCKET_TIMEOUT_CLOSE_THRESHOLD)

        LOGGER.debug('Handling timeout %i with a threshold of %i',
                     self._socket_timeouts, threshold)
        if self.is_closing and self._socket_timeouts > threshold:
            if not self.is_closing:
                LOGGER.critical('Closing connection due to timeout')
            self._on_connection_closed(None, True)

[vitaly-krugl]

Fixed via PR #533