Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pika v1.0.0 breaking change (order of parameters) for the `cha… #1393

Merged
merged 3 commits into from
Nov 27, 2022

Conversation

mprinc
Copy link
Contributor

@mprinc mprinc commented Nov 5, 2022

…nnel.basic_consume` method

Proposed Changes

Please describe the big picture of your changes here to communicate to
the Pika team why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue.

A pull request that doesn't explain why the change was made has a
much lower chance of being accepted.

If English isn't your first language, don't worry about it and try to
communicate the problem you are trying to solve to the best of your
abilities. As long as we can understand the intent, it's all good.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask on the
pika-python
mailing list. We're here to help! This is simply a reminder of what we
are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further Comments

If this is a relatively large or complex change, kick off the discussion
by explaining why you chose the solution you did and what alternatives
you considered, etc.

Copy link
Member

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are some conflicts to resolve

@mprinc
Copy link
Contributor Author

mprinc commented Nov 6, 2022

Seems like there are some conflicts to resolve

Yes, strange, maybe something got in from my later extension with channel.start_consuming() threaded ... anyway should be fixed now

@lukebakken lukebakken self-assigned this Nov 27, 2022
@lukebakken lukebakken added this to the 2.0.0 milestone Nov 27, 2022
@lukebakken lukebakken merged commit 6195ea1 into pika:main Nov 27, 2022
@lukebakken
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants