Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong fonts for iOS 10 #10

Closed
dimovskidamjan opened this issue Oct 10, 2016 · 10 comments
Closed

Wrong fonts for iOS 10 #10

dimovskidamjan opened this issue Oct 10, 2016 · 10 comments

Comments

@dimovskidamjan
Copy link

The fonts for the iOS10 style notification are wrong:
The title should be System Light 13, and the message System Regular 15. Please update these to achieve a more authentic experience for the users.

@pikacode
Copy link
Owner

@dimovskidamjan
Maybe some pull requests? I'm so busy recently 😅

@dimovskidamjan
Copy link
Author

@pikacode No problem, I will try to do this in the following days.

@pikacode
Copy link
Owner

@dimovskidamjan Thank you so much! ^。^

@pikacode
Copy link
Owner

@dimovskidamjan

  • And actually It seems that there is some shadows behind the iOS 10 banner, I tried to add it, but failed 😅
  • iOS 10 foreground notification banner is supported by system, maybe there is no need to create a EBBannerView anymore

@dimovskidamjan
Copy link
Author

@pikacode I will refactor it to show the system banner on iOS 10 and still show EBBannerView for iOS 9, so both will be covered.

@Huang-Libo
Copy link

期待 iOS 10 的适配

@pikacode
Copy link
Owner

@Huang-Libo 哥们一起帮忙改进代码呗,提提 pull request。我最近确实太忙。

@Huang-Libo
Copy link

@pikacode 我还没看 EBForeNotification 的源码,有空先观摩观摩。

@pikacode
Copy link
Owner

@Huang-Libo
你好,这个仓库已经不再维护,你可以使用新的仓库 EBBannerView。它对此进行了重构,并且提供更多你想不到的强大功能,欢迎使用 :)

@Huang-Libo
Copy link

@pikacode 资兹!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants