Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & fix react messaging #188

Merged
merged 1 commit into from Feb 4, 2020
Merged

Update & fix react messaging #188

merged 1 commit into from Feb 4, 2020

Conversation

FredKSchott
Copy link
Owner

@FredKSchott FredKSchott commented Feb 4, 2020

For the Pika CDN, we now actively maintain ESM versions of React & React-DOM. So now we can start pointing to those in our docs instead of @sdegutis's (which were great, but no longer appear to be maintained).

While doing that, I discovered that in many cases these custom messages weren't being displayed. I fixed that, and added some tests.

Copy link
Contributor

@yukukotani yukukotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just to make sure, would @pika/react be open source?
Closed source may cause the anxiety about being abandoned.

@FredKSchott
Copy link
Owner Author

Of course, that's a good point. I'll open source the repo I'm using to build it tomorrow, which is really just a wrapper around https://www.npmjs.com/package/react-ecmascript

@FredKSchott FredKSchott merged commit 47f9b97 into master Feb 4, 2020
@FredKSchott FredKSchott deleted the update-react-message branch February 4, 2020 10:52
@drwpow
Copy link
Collaborator

drwpow commented Feb 4, 2020

Interesting! I myself have taken a crack at building ESM versions of React. It’s not impossible, but it is a bit of work based on their pipeline.

It’d be nice of react-ecmascript if it kept up with React versions (that repo seems 13 months old?).

Maybe with my spare time in the next few weeks I could look into helping that project fill out the missing React versions.

@FredKSchott
Copy link
Owner Author

Yea, it's a bit of a pain but https://www.npmjs.com/package/react-ecmascript takes care of the worst of it.

The nice thing is that you can tell it which version to build, so even though the repo is old my script uses it to build the latest React v16.12.0.

Here's the repo! https://github.com/pikapkg/react

The only thing that I'd like to add is a GitHub Action that runs nightly, checks for the latest React release, and rebuilds/publishes to npm automatically. I have an automatic job that I can run on my computer, but it still requires human intervention for me to publish the package itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants