Better code styling (back to Rouge) #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wJoenn
reviewed
Dec 3, 2023
wJoenn
previously requested changes
Dec 3, 2023
pil0u
reviewed
Dec 3, 2023
Aquaj
force-pushed
the
feature/better-code-styling
branch
from
149e9e8
to
12bf582
Compare
pil0u
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes and context
Commonmarker 1.0 se repose sur comrak qui elle-même se repose sur syntect. Syntect ne supporte (pour l'instant?) que les syntaxes de langage supportées par SublimeText par défaut.
C'est trop limitant, bcp de langages modernes ne sont pas dedans (particulièrement TypeScript).
L'ancienne version de Commonmarker se repose sur libcmark-gfm et n'a pas autant d'options, mais permet de parcourir l'AST du Markdown avant génération du HTML. Cette PR revient donc à cette version de Commonmarker afin d'exploiter cette feature pour re-process les
code_blocks, leur set le langage par défaut (vu que l'option n'existe pas dans cette version), puis les passer dans Rouge pour s'occuper de la coloration syntaxique au lieu desyntect.Fixes #387.
Rendu final:
