Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ir - added decode function for RC6 remotes #197

Open
wants to merge 1 commit into
base: ir
Choose a base branch
from
Open

Ir - added decode function for RC6 remotes #197

wants to merge 1 commit into from

Conversation

tobid89
Copy link

@tobid89 tobid89 commented Sep 27, 2015

If I did something wrong with the request, let me know.

First I merged the latest dev to the ir branch and after that I added my function.

Greetings,
tobid

@CurlyMoo
Copy link
Contributor

First of all, don't close the PR.

Please do the PR according to the contribution guide. Also, don't merge the dev branch, but keep it plain IR branch.

@tobid89
Copy link
Author

tobid89 commented Sep 27, 2015

For me the PR is still open or what do you mean with closed?

I did the merging because I could not compile the plain ir branch. I got some linker issues due to missing zwave includes that I could not fix by editing the cmake files.

Unfortunately I am one week of now. Should I delete the PR and create a new one as soon as I am back home?

@CurlyMoo
Copy link
Contributor

Unfortunately I am one week of now. Should I delete the PR and create a new one as soon as I am back home?

Exactly what i do not want you to do.

So revert everything, commit again, add your code, commit again, merge all commits.

@tobid89
Copy link
Author

tobid89 commented Oct 4, 2015

Hopefully I did everything right. Here is the single commit!

printf("%d ", generic_ir->raw[i]);
}
printf("\n");

while(tmp_remotes) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenting isn't correct from here on

@tobid89
Copy link
Author

tobid89 commented Oct 5, 2015

Sry, I don't unterstand what you are meaning with "indenting". Do you mean the spaces?

Btw: I can not change it immediatly, because I am home only on weekends.

@pilino1234
Copy link
Member

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants