Logilink EC0003 for Rewrite-Branch

[hernae]

See PR from development branch

[CurlyMoo]

Thanks, can you also include this protocol in the unit tests?

[hernae]

I added them but I am not sure if its 100% correct.

[CurlyMoo]

Can you add a few more? For closed states, some different unitcode and systemcode combinations.

[CurlyMoo]

Also, travis failed due to some include error:
https://travis-ci.org/pilight/pilight/builds/281927083?utm_source=github_status&utm_medium=notification

[CurlyMoo]

Can you check the travis output yourself and make sure it at least compiles?

[hernae]

Yeah sorry, I am at it..

[CurlyMoo]

Almost there 👍

[hernae]

Hmm I dont know atm why the unit test fails. I have to look next week into it..

[CurlyMoo]

You can run the unit tests locally as well. Then you don't have to wait for the full travis run.

[hernae]

How do I do that?

[pilino1234]

Set -DPILIGHT_UNITTEST=1 when running cmake, then run the pilight-unittest executable after compilation has finished.

Note that there are a couple of unittests infamous for failing notoriously, see this from one of my PRs (those last 4 builds always fail due to certain tests…) 😆
In case these fail, just restart the tests until those tests pass. I've considered commenting them out for a while (in tests/alltests.c), that works too 😛

[hernae]

This will compile solely on the rpi, right? Because I don't wanna corrupt my currently running pilight application on my rpi, I am just developing on my pc with notepad++.

Normally I just develop C# and use Visual Studio. Can I use VS for developing or is there another ide I could use? How have you setup your environment when developing for pilight?

[CurlyMoo]

This will compile solely on the rpi, right?

Or any other unix system. You can run the unit test with having to install anything.

[pilino1234]

Normally I just develop C# and use Visual Studio. Can I use VS for developing or is there another ide I could use? How have you setup your environment when developing for pilight?

I'd recommend an actual IDE rather than a (advanced) text editor like notepad++. I've had good experience with Jetbrains CLion (which costs however, although it's free for students :D ). Otherwise code::blocks is quite good too.

[CurlyMoo]

notepad++

I never use differently.