Handle invalid status codes

pillarjs · Jun 19, 2014 · a75d6a8 · a75d6a8
1 parent 9d2d23e
commit a75d6a8
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * Handle invalid status codes
+
 0.0.1 / 2014-06-05
 ==================
 

diff --git a/index.js b/index.js
@@ -52,7 +52,7 @@ function finalhandler(req, res, options) {
     // unhandled error
     if (err) {
       // default status code to 500
-      if (res.statusCode < 400) {
+      if (!res.statusCode || res.statusCode < 400) {
         res.statusCode = 500
       }
 

diff --git a/test/test.js b/test/test.js
@@ -104,6 +104,20 @@ describe('finalhandler(req, res)', function () {
         .expect(414, done)
       })
     })
+
+    describe('when res.statusCode undefined', function () {
+      it('should set to 500', function (done) {
+        var server = http.createServer(function (req, res) {
+          var done = finalhandler(req, res)
+          res.statusCode = undefined
+          done(new Error('oops'))
+        })
+
+        request(server)
+        .get('/foo')
+        .expect(500, done)
+      })
+    })
   })
 
   describe('request started', function () {