Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove debug #4

Closed
wants to merge 1 commit into from
Closed

deps: remove debug #4

wants to merge 1 commit into from

Conversation

chulkilee
Copy link

It is extraneous dependency if you do not need debug. Even for debug, it would be better to have events system instead of using debug package.

@Fishrock123
Copy link
Member

Don't think this will be happening. Debug is used all across express.

(@dougwilson don't we usually use a different debug package though?)

@chulkilee
Copy link
Author

I get the point (ref), but I don't think this package is limited to express.

By the way it seems like the same debug package with express.

@Fishrock123
Copy link
Member

Does this cause you any significant non-package-install overhead? if not, I'm inclined to close this, as it would require an alternative to be provided for all such modules that we maintain.

@chulkilee
Copy link
Author

Understood - closing it. Thanks for the quick response!

@dougwilson
Copy link
Contributor

Yea, this module is not being removed. It's the de-facto debugging module in the Node.js community (since Node.js core does not offer such a feature) and your PR will prevent people from ever debugging what is happening inside this module.

An "events system" is not viable, because this module may be used deep, deep in the dependency chain and people cannot access a reference to this module.

If there is some mass exodus from using this module across npm, then maybe if there is an alternative, but I have not seen such a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants