Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support params for async helper #131

Merged
merged 1 commit into from Sep 6, 2016

Conversation

draconisNoctis
Copy link
Contributor

No description provided.

@defunctzombie
Copy link
Collaborator

can you describe what this is for/what it does please

@draconisNoctis
Copy link
Contributor Author

draconisNoctis commented Sep 1, 2016

�It passes all given parameters (and the context) to the registered async helper, just like the synchronous helper does.

Previously, only one parameter was passed (or the context, if no parameters was set). So you couldn't use an async helper with more than one parameter (or parameter(s) + context).

@defunctzombie
Copy link
Collaborator

Any thoughts on why the tests are failing? The code looks good to me but failing CI concerns me. Should we just remove the express 3 checks and just stick with 4 now?

@defunctzombie
Copy link
Collaborator

I updated/fixed the tests on master so if you rebase those should get fixed up.

@draconisNoctis
Copy link
Contributor Author

I rebased my fork, CI shouldn't fail anymore.

@defunctzombie defunctzombie merged commit 75dd9a6 into pillarjs:master Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants