Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code to run on Powersystem #236

Closed
wants to merge 3 commits into from

Conversation

genisysram
Copy link

Hi
Here is my contribution to your code, its working good on powersystems.

Thanks for the code, its working good.

What do these changes do?

Added Architecture "ppc64le"

Are there changes in behavior for the user?

No

@dougwilson
Copy link
Contributor

Thank you for your contribution, but this is a pure-JS module which does not use any native modules in Node.js, so there isn't really a need to test on various architectures within this project. This change further ties us in to Travis CI, which is in the process of being removed from our projects due to it no longer being free. All the extra builds this adds to the project will quickly use up my fee credits on Travis CI before I have the chance to finish migrating away.

@dougwilson dougwilson closed this Dec 14, 2020
@dougwilson dougwilson added the pr label Dec 14, 2020
@genisysram
Copy link
Author

1)we esures that all node js work with this architecture
2) if you are running out of credits , you can request through, support.travis-ci.com ( if you are not successful , get back to me I will help you in this regard.

@dougwilson
Copy link
Contributor

Hi and thanks for the offer. But I'm not going to keep requesting credits over and over. Instead I am just moving the projects to test in GitHub Actions, which are free and does not require me to keep requesting credits :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants