case sensitive file handling #177
Conversation
|
is there any diference betwene the tracis ci coverage reporter and the local one localy i get the following coverage results : Statements : 99.77% ( 425/426 ) |
| if (dir === path.dirname(dir)) { | ||
| return true | ||
| } | ||
| var filenames = fs.readdirSync(dir) |
There was a problem hiding this comment.
We should really do this using an async method; sync methods will block the event loop and processing of all I/O in the process while the read occurs, and it could be against a network share, for example.
| ##### caseSensitive | ||
|
|
||
| When set to `true` all the requests against the file system are made case sensitive even on case insensitive file systems. | ||
| This effects not only the file name but the whole path. |
There was a problem hiding this comment.
(this is just a comment) I assume by "whole path" that includes what was provided also as the root option? If so, it should probably call that out, as there is the input named path, which may be mistake for "the whole path" in this wording.
|
|
||
| When set to `true` all the requests against the file system are made case sensitive even on case insensitive file systems. | ||
| This effects not only the file name but the whole path. | ||
| When set to `false` the default behavior of the filesystem is used. |
There was a problem hiding this comment.
Passing in caseSensitive: false does have a weird feel to the API... it feels like it should thus not be case-sensitive, vs depend on the file system. I'm trying to think of a good API name for this functionality, and don't have a good one.
Would it be possible to maybe even make caseSensitive: false work? For example, to have this option be true, or false, or 'fs'? If not, as I cannot think of a good API name that would make sense as true/false, maybe use a string like 'fs'instead of acceptingfalse`?
| @@ -546,6 +548,7 @@ SendStream.prototype.pipe = function pipe (res) { | |||
|
|
|||
| // join / normalize from optional root dir | |||
| path = normalize(join(root, path)) | |||
| root = normalize(root + sep) | |||
There was a problem hiding this comment.
What is this doing, exactly?
This is ment to solve this issue expressjs/serve-static#93.
It contains a fix to handel files on in case insensitive file system case sensitive.