This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
add gossip Closer #1483
Merged
add gossip Closer #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanbernstein
previously approved these changes
Jul 10, 2018
There was a problem hiding this comment.
This seems to resolve both of the issues I noticed in #1473
jaffee
reviewed
Jul 10, 2018
gossip/gossip.go
Outdated
| @@ -93,6 +93,17 @@ func (g *memberSet) Open() (err error) { | |||
| return nil | |||
| } | |||
|
|
|||
| // Close attempts to gracefully leaves the cluster, and finally calls shutdown | |||
jaffee
previously approved these changes
Jul 10, 2018
alanbernstein
approved these changes
Jul 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR attempts to
Leave()/Shutdownthe memberlist gossip onserver.Close().This frees up the two file handles held by memberlist networking.
Fixes #1479
Pull request checklist
Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.