Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Import benchmarking #1771

Merged
merged 6 commits into from
Dec 12, 2018
Merged

Import benchmarking #1771

merged 6 commits into from
Dec 12, 2018

Conversation

jaffee
Copy link
Member

@jaffee jaffee commented Dec 7, 2018

Overview

Adds a series of benchmarks for importing into fragments and then updating them

Fixes #

Pull request checklist

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.

@jaffee jaffee requested a review from seebs December 7, 2018 19:40
@jaffee jaffee force-pushed the import-benchmarking branch 2 times, most recently from bd604b4 to b731175 Compare December 9, 2018 18:10
fragment_internal_test.go Outdated Show resolved Hide resolved
seebs
seebs previously approved these changes Dec 11, 2018
Copy link
Contributor

@seebs seebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight lingering concerns about the unchecked possible errors from deferred Clean() calls, but I think this is reasonable as-is. Didn't fully vet every detail, but I checked where timers are started and stopped and things like that, and it looked reasonable.

Copy link
Contributor

@seebs seebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@jaffee jaffee merged commit 6ed5da1 into FeatureBaseDB:master Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants