Make Falco.Markup optional / pluggable / replacable

[pkese]

I really like Falco, but prefer to use Feliz.ViewEngine style html rendering instead of Falco.Markup (I'm used to Feliz from frontend and I'd like to use it on backend as well to reduce surface area).

Would it be possible to split Falco.Markup out completely, so that if it isn't explicitly installed as a package, it doesn't pollute the namespace. Currently Falco.Markup is pulled in unconditionally:

Falco/src/Falco/Response.fs

Line 10 in a2ff74f

open Falco.Markup

If it was optional, then one could supply their own response.ofHtml that would let them render their own document type (rather than just Falco.Markup).

Falco/src/Falco/Response.fs

Line 167 in a2ff74f

ofHtmlString (renderHtml html)

[pimbrouwers]

Hey Peter,

Thanks for reaching out.

When the Markup module was broken out, my number 1 goal was to ensure backward compatibility with the API at the time (which remains today). With that in mind, this concept isn't possible. I tried, trust me.

But that said, it costs you virtually nothing (we're talking kilobytes in your final DLL or exe), and I'm not sure it's inclusion in the Response and Xss modules is "polluting the namespace".

I don't see it as a problem in any way to just include & use whatever view engine you'd like :)

[pkese]

Ok. I added extra rendering to response and it works fine. Sorry for the inconvenience.

BTW, thanks for the wonderful library, it's really clean and concise ... no new operators and at just the right level of abstraction. Brilliant!

[pimbrouwers]

No bother whatsoever. It grinds me that I wasn't able to achieve this 2 yrs ago. I am so glad you like it! I find it a nice tribute to ASPNET. Gabe us the minimal API feel before we had minimal APIs officially!

…

On Fri, Jan 5, 2024, 6:11 PM Peter Keše ***@***.***> wrote: Ok. I added extra rendering to response and it works fine. Sorry for the inconvenience. BTW, thanks for the wonderful library, it's really clean and concise ... no new operators and at just the right level of abstraction. Brilliant! — Reply to this email directly, view it on GitHub <#117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDB57PBUVK3YCI23KFM3JLYNCCBNAVCNFSM6AAAAABBONARVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGM3DKOJWGM> . You are receiving this because you commented.Message ID: ***@***.***>