Feature/add support for an in filter operator to grid helper #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be merged after |
After pimcore/pimcore:v11.1.0 |
|
@mfedak-notebooksbillger Looks Good. But could you please refactor the code in override.js such that we don't need to take care of the existing options like gt,lt,eq etc. Like we do for Quantity Value using the inheritance here |
|
@mfedak-notebooksbillger Thank you for the PR. We will focus on the refactoring #115 (comment) in a follow up PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Add support for an 'in' filter operator when filtering numerical fields in the grid.
Additional info
At Notebooksbilliger we had a need to filter a column in the grid with multiple values. We have created our own bundle to achieve this but we did have to modify some core code. We are currently changing this core file using a composer patch but would love to see this extra operator check included in future.
Example: https://beta.im.ge/i/in-filter-numeric-columns.FM5r79
(Is related to pimcore/pimcore#15315)