Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2FA authentication for firewalls other than admin #345

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix 2FA authentication for firewalls other than admin #345

merged 1 commit into from
Nov 10, 2023

Conversation

dvesh3
Copy link
Contributor

@dvesh3 dvesh3 commented Nov 10, 2023

Steps to reproduce:

  1. Setup 2FA for non admin firewall (e.g. simple setup email https://symfony.com/bundles/SchebTwoFactorBundle/6.x/providers/email.html#how-authentication-works)
  2. login
  3. No 2FA executed

@dvesh3 dvesh3 added the Bug label Nov 10, 2023
@dvesh3 dvesh3 added this to the 1.2.2 milestone Nov 10, 2023
@kingjia90 kingjia90 self-assigned this Nov 10, 2023
@kingjia90 kingjia90 merged commit e412b05 into 1.2 Nov 10, 2023
7 checks passed
@kingjia90 kingjia90 deleted the fix_2fa_non_admin branch November 10, 2023 11:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kingjia90 kingjia90

Labels
Bug Security
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvesh3 @kingjia90