Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken image editor #378

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Fix broken image editor #378

merged 2 commits into from
Jan 15, 2024

Conversation

elmarputz
Copy link
Contributor

This PR targets the problem described here: pimcore/pimcore#16388

Image editing didn't work anymore, because the load event didn't wait for the canvas to be fully loaded.

fix image editor in Pimcore 11
Copy link

github-actions bot commented Dec 21, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@elmarputz
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@elmarputz
Copy link
Contributor Author

recheck

1 similar comment
@elmarputz
Copy link
Contributor Author

recheck

@kingjia90 kingjia90 added the Bug label Jan 9, 2024
@kingjia90 kingjia90 changed the base branch from 1.x to 1.3 January 9, 2024 09:40
@kingjia90 kingjia90 added this to the 1.3.2 milestone Jan 9, 2024
@kingjia90 kingjia90 self-assigned this Jan 11, 2024
@kingjia90 kingjia90 merged commit ee9fe48 into pimcore:1.3 Jan 15, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants