Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider & showing Platform Version when installed #568

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

fashxp
Copy link
Member

@fashxp fashxp commented Jun 14, 2024

shows platform version in pimcore logo tooltip and about window if installed

depending on pimcore/pimcore#17179 and pimcore/pimcore:11.3.0

@fashxp fashxp added this to the 1.5.0 milestone Jun 14, 2024
@brusch
Copy link
Member

brusch commented Jun 17, 2024

Tests failing because of requiring not yet released version of pimcore/pimcore - so should be all fine.

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kingjia90 kingjia90 merged commit db29c04 into 1.x Jun 18, 2024
9 checks passed
@kingjia90 kingjia90 deleted the consider-platform-version branch June 18, 2024 09:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants